feat(shield): convert alf config to secret #2303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cret for the local forwarder configuration
charts/shield/values.yaml
Outdated
| # the local forwarder secret generation is skipped and the existing secret | ||
| # name is used to mount the secret volume instead of the one defined in | ||
| # the secrets template | ||
| existing_secret_name: "" |
There was a problem hiding this comment.
Suggested change
| existing_secret_name: "" | |
| existing_secret: "" |
let's align with all the other existing_secrets removing the _name suffix
maybe we can add a prefix to clarify what it replaces
# Conflicts: # charts/shield/Chart.yaml # charts/shield/tests/host/daemonset_test.yaml # charts/shield/tests/host/secrets_test.yaml
francesco-furlan
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
SSIA
Checklist
feat(agent,node-analyzer,sysdig-deploy):)